Render id={form.identifier} around ConfirmationFinisher

[paavo]

Adds a div container with the form identifier to the ConfirmationFinisher so that it is scrolled into view upon invokation

Resolves: #130

[bwaidelich]

@paavo Thanks a lot for this. I tweaked the PR description a little and will look into this asap

[bwaidelich]

I still didn't get around looking deeper into this.
But there is a fundamental issue with that that prevents me from just hitting the "Merge" button:
Finishers should be mostly independent from the Form rendering since they can be used in all kinds of context (e.g. CLI forms).

The change makes a lot of sense for the general case, but it should probably be configurable in some way..

For now I would suggest to use a custom Finisher (in general I think it was a mistake to ship the core form framework with all the element and finisher implementations).

In this case, you should be able to achieve the fixed behavior with sth like

class CustomConfirmationFinisher extends ConfirmationFinisher {
   protected function executeInternal() {
       parent::executeInternal();
       $formRuntime = $this->finisherContext->getFormRuntime();
       $formRuntime->getResponse()->setContent('<div id="' . $formRuntime->getIdentifier() . '">' . $formRuntime->getResponse()->getContent() . '</div>');
   }
}

[paavo]

Thanks for your Input @bwaidelich

Finishers should be mostly independent from the Form rendering since they can be used in all kinds of context (e.g. CLI forms).

I didn't knew about that, but makes sense.

I just wrapped a Container (with the Form-ID) around the Form (including the ConfirmationFinisher) in Fusion.

[bwaidelich]

Thanks for the update!