FEATURE: Allow to set a specific URL for the redirect finisher #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,4 +80,28 @@ public function setOptions(array $options) | |||
| { | |||
| $this->options = $options; | |||
| } | |||
|
|
|||
| /** | |||
| * @param $request | |||
daniellienert
force-pushed
the
feature/allow-to-set-a-url-in-redirect-finisher
branch
from
a02118b
to
4910bc9
Compare
This change adds the option to allow a specific URL to be set for the redirect finisher. Also some cleanup / refactoring is done.
daniellienert
force-pushed
the
feature/allow-to-set-a-url-in-redirect-finisher
branch
from
4910bc9
to
d3a7338
Compare
|
Thanks @aertmann for reviewing. |
sets the header / body output to the current response object instead of the topmost parent.
|
@aertmann / @kdambekalns: While testing, it showed, that the output / the redirect header wasn't rendered. Originally the topmost parent response object was altered - I guess for a reason? When I alter the current response object everything works fine. I wonder why this ever worked? What do you think? |
|
Off the top of my head, maybe neos/neos-development-collection#16 causes this? |
daniellienert
deleted the
feature/allow-to-set-a-url-in-redirect-finisher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the option to allow a specific URL
to be set for the redirect finisher. Also some cleanup /
refactoring is done.