Skip to content

Commit

Permalink
Adjust legacy migration and labels to hiddenInMenu
Browse files Browse the repository at this point in the history
  • Loading branch information
kitsunet authored and mhsdesign committed Apr 26, 2024
1 parent f9808e2 commit 565bff1
Show file tree
Hide file tree
Showing 33 changed files with 77 additions and 77 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ public function extractPropertyValuesAndReferences(array $nodeDataRow, NodeType

// hiddenInIndex is stored as separate column in the nodedata table, but we need it as (internal) property
if ($nodeDataRow['hiddeninindex']) {
$properties['_hiddenInIndex'] = true;
$properties['hiddenInMenu'] = true;
}

if ($nodeType->isOfType(NodeTypeName::fromString('Neos.TimeableNodeVisibility:Timeable'))) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ protected function getPropertyPath($element, $propertyPath)
if ($propertyPath === '_identifier') {
// TODO: deprecated (Neos <9 case)
return $element->nodeAggregateId->value;
} elseif ($propertyPath[0] === '_' && $propertyPath !== '_hiddenInIndex') {
} elseif ($propertyPath[0] === '_') {
return ObjectAccess::getPropertyPath($element, substr($propertyPath, 1));
} else {
return $element->getProperty($propertyPath);
Expand Down
4 changes: 2 additions & 2 deletions Neos.Neos/Classes/Fusion/AbstractMenuItemsImplementation.php
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,12 @@ abstract protected function buildItems(): array;
protected function isNodeHidden(Node $node)
{
if ($this->getRenderHiddenInMenu() === true) {
// Please show hiddenInIndex nodes
// Please show hiddenInMenu nodes
// -> node is *never* hidden!
return false;
}

// Node is hidden depending on the _hiddenInIndex property
// Node is hidden depending on the hiddenInMenu property
return $node->getProperty('hiddenInMenu');
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">جزء من مسار URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">إخفاء في القوائم</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">إخفاء في القوائم</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">Segment cesty adresy URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Skrýt v menu</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Skrýt v menu</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="final">URL adressesegment</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Skjul i menuer</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Skjul i menuer</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<trans-unit id="properties.uriPathSegment" xml:space="preserve" approved="yes">
<source>URL path segment</source>
<target state="final">URL Pfadsegment</target></trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve" approved="yes">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">In Menüs verbergen</target></trans-unit>
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="needs-translation">URL path segment</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Κρυφό στα μενού</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Κρυφό στα μενού</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<trans-unit id="properties.uriPathSegment" xml:space="preserve">
<source>URL path segment</source>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
</trans-unit>
</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">Segmento de ruta de URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Ocultar en los menús</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Ocultar en los menús</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="final">URL-polun osa</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Piilota valikoissa</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Piilota valikoissa</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="final">Segment d'URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Cacher dans les menus</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Cacher dans les menus</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">URL szegmens</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Elrejtés a menüben</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Elrejtés a menüben</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">Segmen path URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Sembunyikan di Menu</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Sembunyikan di Menu</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">Segmento di percorso URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Nascondi nei menu</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Nascondi nei menu</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">URL パスセグメント</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">メニュー非表示</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">メニュー非表示</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="final">បំណែកផ្លូវនៃតំណ</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">មិនបង្ហាុញក្នុងមីនុយ</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">មិនបង្ហាុញក្នុងមីនុយ</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="final">URL segments</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Paslēpt izvēlnē</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Paslēpt izvēlnē</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="final">URL pad segment</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Verberg in menu's</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Verberg in menu's</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">URL-banesegment</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Skjul i menyer</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Skjul i menyer</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="final">Segment ścieżki URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Ukryj w menu</target>
<trans-unit id="properties.hiddenInMenu" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Ukryj w menu</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<source>URL path segment</source>
<target state="translated">Segmento de caminho de URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Ocultar em menus</target>
</trans-unit>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">Segmento de URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Esconder em menus</target>
<target state="translated">Esconder em menus</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="final">Сегмент пути URL-адреса</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve" approved="yes">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve" approved="yes">
<source>Hide in menus</source>
<target state="final">Скрыть в меню</target>
<target state="final">Скрыть в меню</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">Сегмент URL путање</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Сакривено у менију</target>
<target state="translated">Сакривено у менију</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">URL-sökvägssegment</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Dölj i menyer</target>
<target state="translated">Dölj i menyer</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="needs-translation">URL path segment</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="needs-translation">Hide in menus</target>
<target state="needs-translation">Hide in menus</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">URL yolu segmenti</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Menülerde gizle</target>
<target state="translated">Menülerde gizle</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">Сегмент адреси URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Сховати до меню</target>
<target state="translated">Сховати до меню</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">Phân đoạn đường dẫn URL</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">Ẩn trong menu</target>
<target state="translated">Ẩn trong menu</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">URL 路径段</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">在菜单中隐藏</target>
<target state="translated">在菜单中隐藏</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<source>URL path segment</source>
<target state="translated">網址路徑</target>
</trans-unit>
<trans-unit id="properties._hiddenInIndex" xml:space="preserve">
<trans-unit id="properties.hiddenInMenu" xml:space="preserve">
<source>Hide in menus</source>
<target state="translated">於選單中隱藏</target>
<target state="translated">於選單中隱藏</target></trans-unit>
</trans-unit>
</body>
</file>
Expand Down

0 comments on commit 565bff1

Please sign in to comment.