Skip to content

Commit

Permalink
Fix typos
Browse files Browse the repository at this point in the history
Co-authored-by: Wilhelm Behncke <2522299+grebaldi@users.noreply.github.com>
  • Loading branch information
mhsdesign and grebaldi committed Apr 22, 2024
1 parent f09f070 commit 80ce33a
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Neos.Fusion/Classes/Core/LegacyFusionControllerContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ public function getFlashMessageContainer(): FlashMessageContainer
*
* Gives access to the legacy mutable action response simulation {@see Runtime::withSimulatedLegacyControllerContext()}
*
* Initially it was possible to mutate the current response of the active MVC controller though this getter.
* Initially it was possible to mutate the current response of the active MVC controller through this getter.
*
* While *HIGHLY* internal behaviour and *ONLY* to be used by Neos.Fusion.Form or Neos.Neos:Plugin
* this legacy layer is in place still allows this functionality.
* this legacy layer is in place to still allow this functionality.
*
* @deprecated with Neos 9.0 can be removed with 10
* @internal THIS SHOULD NEVER BE CALLED ON USER-LAND
Expand Down
5 changes: 3 additions & 2 deletions Neos.Fusion/Classes/Core/Runtime.php
Original file line number Diff line number Diff line change
Expand Up @@ -954,9 +954,9 @@ protected function throwExceptionForUnrenderablePathIfNeeded($fusionPath, $fusio
/**
* Implements the legacy controller context simulation {@see self::getControllerContext()}
*
* Initially it was possible to mutate the current response of the active MVC controller though $response.
* Initially it was possible to mutate the current response of the active MVC controller through $response.
* While HIGHLY internal behaviour and ONLY to be used by Neos.Fusion.Form or Neos.Neos:Plugin
* this legacy layer is in place still allows this functionality.
* this legacy layer is in place to still allow this functionality.
*
* @param \Closure(): (ResponseInterface|StreamInterface) $renderer
*/
Expand All @@ -968,6 +968,7 @@ private function withSimulatedLegacyControllerContext(\Closure $renderer): Respo
$this->legacyActionResponseForCurrentRendering = new ActionResponse();

// actual rendering
$httpResponseOrStream = null;
try {
$httpResponseOrStream = $renderer();
} finally {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ abstract class AbstractFusionObjectTest extends FunctionalTestCase
/**
* TODO THIS IS HACKY AS WE CREATE AN OWN VIEW
*
* We do that as the FusionView (rightfully) does return mixed anymore.
* We do that as the FusionView (rightfully) doesn't return mixed anymore.
*
* We could instead also rewrite all tests to use the Runtime instead.
*
Expand Down
2 changes: 1 addition & 1 deletion Neos.Fusion/Tests/Functional/View/FusionViewTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function fusionViewOutputsVariable()
/**
* @test
*/
public function fusionVieReturnsStreamInterface()
public function fusionViewReturnsStreamInterface()
{
$view = $this->buildView('Foo\Bar\Controller\TestController', 'index');
$view->assign('test', 'Hallo Welt');
Expand Down

0 comments on commit 80ce33a

Please sign in to comment.