TASK: Split basic fusion prototype files and define defaults #3915
Conversation
This makes it easier to navigate to specific prototypes. Deprecated prototypes are marked and now in a subfolder
This should make it more obvious which fusion parameters are available for each prototype and inspecting the PHP code should not be as necessary anymore.
|
NOICE! 🎉 |
|
Very nice. |
|
+1 but we should be carefull about the single source of truth - maybe generate the docs from the sourcecode? |
|
I thought about the examples too, but would add them in follow-up PRs, as they are more work and better done in batches maybe. |
|
i agree that can be done later. This IS already a big improvement to have all paths of the object written out ;) |
|
i dont think we should start inline documentation, when this code would not be used for the rendered docs (as thoses two things can easily diverge). but currently the fusion ast parser ignores any information about the comments - that would need to be changed... |
|
Then skip for now. We can add a link to the docs later instead of creating full examples inside the fusion files. |
There was a problem hiding this comment.
Seems to work ;)
Question:
Is it now api to include only a specific fusion file from Neos.Fusion?
like
include: resources://Neos.Fusion/Private/Fusion/Value.fusion
i would be against promoting that pattern - as it would not allow us to use the pattern of
moving deprecated objects to Deprecated in the future.
but how can we tell the dev to not do that but use include: resources://Neos.Fusion/Private/Fusion/Root.fusion ?
(same goes for Neos.Neos Root.fusion should be "api" everything else not.)
Neos.Fusion/Resources/Private/Fusion/Deprecated/Attributes.fusion
Outdated
Show resolved
Hide resolved
This allows including only the non deprecated prototypes from other packages if that is desired.
|
yes we often had that plan ^^ it was even proposed to remove them directly next release (that would have been neos 5 ^^) so i guess its gonna be 9.0 since we missed it with 8.0 |
|
What about a soft removal in 8.3 by only removing the include – so |
|
even if this would be technically breaking - one can easily fix that as you said. ... but on the other hand if we could provide a good migration (i think we have already one?) then it should be quite easy to adjust the code and should not require a special soft removal? |
|
There is a migration and we should target 9.0 for this. |
|
we missed |
|
Shame shame shame! |
|
😂😂 too bad i guess fusion will collapse now and burst into fire. Ill fix it once im on my pc ^^ |
|
Ups we may have broke the default error handling in 8.2 https://discuss.neos.io/t/redirect-issue-to-404-not-found-page-in-neos-demo-neos-flow-8-2-0/6169/3?u=marc … needs investigation ;) |
Splits the Fusion prototypes in Neos.Neos and Neos.Fusion into separate files and adds all available parameters of the PHP implementations also in Fusion.
This should make it easier for integrators to understand which options are available for each prototype without reading the their PHP implementation code.
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions