Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Neos.Neos Fusion ErrorCase wrongly included #4054

Merged
merged 1 commit into from Feb 23, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Feb 23, 2023

Fixes: #4035

#3915 introduced a regression, that the errorCase was not included at all. With #3996 this was hotfixed but lead to another regression that i am here to fix.

If we include Neos.Neos/Resources/Private/Fusion/Error/Root.fusion we also re include include: resource://Neos.Fusion/Private/Fusion/Root.fusion which is not optimal.

The errorCase is now (again) on its own and doesnt belong to the Error folder anymore but like the RootCase, sits on top.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@ahaeslich ahaeslich merged commit 0f493c7 into 8.2 Feb 23, 2023
@ahaeslich ahaeslich deleted the bugfix/4035-errorCaseWronglyIncluded branch February 23, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants