TASK: Use generateRandomString() instead of uniqid() #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the risk of collision on temporary names for nodes and files, as well as cache markers.
|
@kdambekalns, thanks for your PR! By analyzing the history of the files in this pull request, we identified @radmiraal, @robertlemke and @bwaidelich to be potential reviewers. |
kitsunet
approved these changes
Apr 12, 2017
|
Too late, but this seems to break the random node name generation: |
kdambekalns
added a commit
to kdambekalns/neos-development-collection
that referenced
this pull request
Apr 12, 2017
The changed generation of node names must avoid uppercase characters. This is a followup to neos#1523
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Apr 12, 2017
The changed generation of node names must avoid uppercase characters. This is a followup to neos/neos-development-collection#1523
neos-bot
pushed a commit
to neos/typo3cr
that referenced
this pull request
Apr 12, 2017
The changed generation of node names must avoid uppercase characters. This is a followup to neos/neos-development-collection#1523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the risk of collision on temporary names for nodes and
files, as well as cache markers.