BUGFIX: Make sure nodes that are to be discarded are actually publishable #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a test for this would be helpful, either behat or functional |
3 tasks
|
@grebaldi says it's hard for him to get into behat testing right now. Could we merge this now and add an issue to update tests later, as right now this is pretty critical and does not wait? |
|
Can we merge this, please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPO3\Neos\Service\PublishingServicetraverses all children of a node to discard that node recursively. Not all those nodes are actually publishable though, so the following batch discard operation fails with the Exception#1395841899: Nodes in a in a workspace without a base workspace cannot be discarded.So, I added a filter to
TYPO3\Neos\Service\PublishingService::discardNodethat removes all nodes from the to-be-discarded list, that are in a different workspace than the given node.Resolves: #1710