Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Add index that should exist but does not #1786

Merged
merged 1 commit into from Dec 21, 2017

Conversation

kdambekalns
Copy link
Member

Adds an index that should exist but is not picked up by Doctrine, and
thus was deleted by accident in 20170110130253.

See #1375

Adds an index that should exist but is not picked up by Doctrine, and
thus was deleted by accident in 20170110130253.

See neos#1375
@bwaidelich
Copy link
Member

@kdambekalns why is this index not picked up by doctrine and does that mean that future migrationgenerate calls will drop it again? And, if so, shouldn't we add another index to https://github.com/neos/neos-development-collection/blob/master/Neos.Neos/Classes/EventLog/Domain/Model/Event.php#L23-L28 ?

@kdambekalns
Copy link
Member Author

The index probably is not picked up because of the single table inheritance involved. It is only contained in https://github.com/neos/neos-development-collection/blob/3.0/Neos.Neos/Classes/EventLog/Domain/Model/NodeEvent.php#L31-L35

So, yes, any new migration will pick it up again, but since the dropping of an index unrelated to whatever one is working on should (tm) be noticed when checking the migrations… well. :)

@kdambekalns
Copy link
Member Author

But… adding it to the Event class might be worth a try. It just looks weird (too), because the property "does not exist" there.

@kdambekalns kdambekalns merged commit e110ad6 into neos:3.0 Dec 21, 2017
@kdambekalns kdambekalns deleted the bugfix/add-missing-event-index branch December 21, 2017 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants