TASK: Change all uppercase TRUE and FALSE to lowercase in PHP #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstruebing
changed the title
gerhard-boden
suggested changes
Jun 26, 2018
Neos.Fusion/Classes/Core/Parser.php
Outdated
| @@ -174,7 +174,7 @@ class Parser implements ParserInterface | |||
| [^\\\\\'])* | |||
| ) | |||
| )$/x'; | |||
| const SPLIT_PATTERN_VALUEBOOLEAN = '/^\s*(TRUE|FALSE|true|false)\s*$/'; | |||
| const SPLIT_PATTERN_VALUEBOOLEAN = '/^\s*(true|false|true|false)\s*$/'; | |||
There was a problem hiding this comment.
we still need the uppercase variant here
gerhard-boden
approved these changes
Jun 26, 2018
kitsunet
approved these changes
Jun 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a thing at some time I remember and I've found many leftover uppercase true and false.
related to #2098