Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: NodeType->isOfType() respects explicitly removed supertypes #2217

Merged
merged 1 commit into from Oct 24, 2018

Conversation

ComiR
Copy link
Contributor

@ComiR ComiR commented Oct 18, 2018

NodeType->isOfType() returned true if a node type inherited another node types inherited node type which was declared as false in the NodeTypes superTypes.

Check existence of node type in inheritance chain instead of recursing through super types.

@kitsunet kitsunet merged commit 1d8e56a into neos:3.3 Oct 24, 2018
@kdambekalns
Copy link
Member

According to #2147 this should be reverted for the reasons described there, like it was done with #2139 through #2145.

@kdambekalns
Copy link
Member

How to verify it

NodeMixin:
  abstract: true

NodeA:
  superTypes:
    NodeMixin: true

NodeB:
  superTypes:
    NodeA: true
    NodeMixin: false

Check it with $nodeB->isOfType('NodeMixin').

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch

@kdambekalns
Copy link
Member

Fixes #1983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants