Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Continue during create missing child nodes if none defined #2286

Merged
merged 1 commit into from Dec 4, 2018
Merged

TASK: Continue during create missing child nodes if none defined #2286

merged 1 commit into from Dec 4, 2018

Conversation

kdambekalns
Copy link
Member

In createChildNodesByNodeType there is no need to iterate nodes of
types that have no child nodes defined in their type.

@kdambekalns
TASK: Continue during create missing child nodes if none defined
d22093e 
In `createChildNodesByNodeType` there is no need to iterate nodes of
types that have no child nodes defined in their type.
@kdambekalns kdambekalns self-assigned this Nov 23, 2018
jonnitto
jonnitto approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by reading

@jonnitto jonnitto added this to To do in Neos 4.2 & Flow 5.2 Release Board via automation Nov 25, 2018
@jonnitto jonnitto moved this from To do to Needs review in Neos 4.2 & Flow 5.2 Release Board Nov 25, 2018
@jonnitto jonnitto changed the base branch from master to 4.2 November 27, 2018 12:35
@kdambekalns kdambekalns merged commit cb6e2f7 into neos:4.2 Dec 4, 2018
Neos 4.2 & Flow 5.2 Release Board automation moved this from Needs review to Done Dec 4, 2018
@kdambekalns kdambekalns deleted the task/optimize-create-missing-child-nodes branch December 4, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnitto jonnitto jonnitto approved these changes

@robertlemke robertlemke Awaiting requested review from robertlemke

@dfeyer dfeyer Awaiting requested review from dfeyer

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

@kitsunet kitsunet Awaiting requested review from kitsunet

@aertmann aertmann Awaiting requested review from aertmann

Assignees

@kdambekalns kdambekalns

Labels
P: Content Repository T: PHP
Projects
No open projects
Neos 4.2 & Flow 5.2 Release Board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdambekalns @jonnitto