BUGFIX: Repair language label handling #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellienert
requested changes
Sep 5, 2019
Change return type of the function getCacheVersion from integer to string. Also enable strict_types in the xliff service.
|
Oh 🙈 will fix soon.
Daniel Lienert <notifications@github.com> schrieb am Fr. 6. Sep. 2019 um
07:45:
***@***.**** commented on this pull request.
------------------------------
In Neos.Neos/Classes/ViewHelpers/Backend/XliffCacheVersionViewHelper.php
<#2687 (comment)>
:
> @@ -0,0 +1,35 @@
+<?php
+namespace Neos\Neos\ViewHelpers\Backend;
Actually it seems you added the declaration to another file :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2687?email_source=notifications&email_token=AAHXS3VYYNG7YN2VSY5BVFLQIHVAPA5CNFSM4ITSQFF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD32IKY#discussion_r321583165>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHXS3UO24BS4JRQMRMNX7DQIHVAPANCNFSM4ITSQFFQ>
.
--
Von Gmail Mobile gesendet mit dem iPad gesendet - ich bitte Tippfehler zu
entschuldigen.
|
daniellienert
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the adjusting the emberjs codebase the XliffCacheVersion view helper and the xliffUrl has been removed. So the value was missing in the configuration in the initialisation of the l18n handling never worked out.
To get it running again the check for the initialisation has been removed. This patch now adds the view helper again. So that we can render the configuration in the template and the l18n initialisation works like expected.
Thanks to @Sebobo for helping out and finding the issue.