BUGFIX: Change aloha.placeholder labels to new editorOptions

[markusguenther]

This changs the language label ids for the placeholders of the base mixins.

[kdambekalns]

From original comment:

How to verify it
Create a text node or an image node with caption. The placeholders will look like that before the change and the labels will be rendered correctly after the change.

[kdambekalns]

Is this really supposed to go into master? It is declared a bugfix, so it should go into the lowest affected branch.

Also, shouldn't there be a fallback in Neos when resolving those automated translation ids? Or was the id in the placeholder changed by hand to a non-existent value?

[markusguenther]

Oh your right ... so will need to go back to 5.0 I guess but will check that :)

[markusguenther]

@kdambekalns It was introduced in 5.0 with the following commit.
33f415b

So base branch is now 5.0.

[daniellienert]

I am always in favor to get such things cleaned up. But couldn't that be breaking if someone changed that label in its own code?

[markusguenther]

@daniellienert Maybe but then it is broken since the 5.0 release when we changed the yaml configuration. We can also provide the old labels, but as we don`t use it in the core it doesn't make so much sense. Or did I miss something.

[kdambekalns]

Fine with me.

The question about B/C remains, but is out of scope for this change: what happens to translations I have in my XLIFF files that are no longer found, because Neos builds a different ID now when I use label: i18n?

[markusguenther]

When you use i18n and the id has changed and you don`t have a matching label in the in xliff files - you will see the new id or if you define a default value the default.