BUGFIX: Change return types of some Fusion methods to mixed

[ComiR]

ba8d141 introduced the return type string for Fusions RenderViewHelper, so we must always return a string (not null).

[mficzel]

Not sure about that, fusion can technically return anything not only strings. I would rather remove the return type if there is no real reason for it.

[ComiR]

@albe, @kitsunet, @kdambekalns, you were involved in the small discussion in Slack. What do you think?

[kdambekalns]

It says string in the docblock, so it should be string. Or the docblock should be changed to say mixed, when the return tyepe is removed again.

[mficzel]

I would prefer mixed as Fusion will often return DataStructures

[kitsunet]

It really doesn't matter what fusion returns, if fluid says a viewhelper returns strings, then that's that. Although I currently think we have other examples that break that "rule".

[mficzel]

If fluid expects viewHelpers to return strings i agree. This makes fluid pretty much unusable and inextensible to me but hey, i do use pure fusion anyways.

[mficzel]

Looking at fluids code i just found that some helpers like integer (count), mixed (cycle,render,grouped) null(Variable) on renderStatic although the viewHelperInterface says renderStatic should return string.

In total i the fluid viewHelperInterface->renderStatic should be typed mixed and the result of the rendere viewHelper here aswell.

[ComiR]

I now changed it to @return mixed. I followed the render method and changed the annotated return types there too.

[kitsunet]

I am fine with that for now! I guess we need to see what fluid does in the future :) THanks a lot

[mficzel]

This totally makes sense and reflects how fusion is used. Thanks a lot

[albe]

What was said above. Fluid ViewHelpers can indeed return something else than string, even though most docblocks suggest otherwise. See e.g. CountViewHelper which returns an int (yes, simple case).

Merging with previous approvals.