Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Relax version constraint and allow Neos.Fusion.Form 2.0 #3324

Merged

Conversation

mficzel
Copy link
Member

@mficzel mficzel commented Mar 29, 2021

Starting with Neos 5.2 the Neos Package required Neos.Fusion.Form ^1.0 instead of * which will not allow to use version 2.0+ of said package.

This change adjusts the constraint to ^1.0 || ^2.0 to allow projects to benefit from the Fusion.Form Runtime.

Hint: When upmerged to master constraint should be adjusted to ^2.0. If this is forgotten i will take care in a second pr.

Relates: neos/fusion-form#42

@mficzel mficzel marked this pull request as ready for review March 29, 2021 06:52
@mficzel mficzel requested review from albe and Sebobo March 29, 2021 06:58
@albe
Copy link
Member

albe commented Mar 29, 2021

Question: Is 2.0 b/c with 1.0? I guess someone running composer update would otherwise end up with getting v2 installed and his forms no longer working in a patch-level release?

@mficzel
Copy link
Member Author

mficzel commented Mar 29, 2021

@albe there is only a minor change that does not affect Neos.

!!! This change contains a breaking change to version 1.0 as a naming inconsistency was detected !!!
The key form.fieldNamePrefix of the formDefinition has to be changed to form.namespace now. It is quite unlikely that anyone is affected as this never worked as documented and was seldom used anyways since usually the namespace is determined by the request.

So for Neos updating to 2.0 is fine. Also Neos 5.0 and 5.1 require Fusion.Form * which will also fetch the update anyways.

@gerhard-boden gerhard-boden merged commit 5bc73ad into neos:5.2 Apr 6, 2021
@albe
Copy link
Member

albe commented Apr 25, 2021

Just noticed the When upmerged to master constraint should be adjusted to ^2.0. If this is forgotten i will take care in a second pr. hint when creating the release notes and now saw it was striken through - is this still something todo or not necessary any more? If so, why?

@mficzel
Copy link
Member Author

mficzel commented Apr 25, 2021

@albe It is not necessary. Neos demo needs and requires 2.0 and Neos itself can run with both. So the current solution is actually more correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants