-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Adjust contributing section to composer changes #3367
Conversation
When installing for development purposes, `--prefer-install=auto` needs to be used since Composer 2.1, see https://getcomposer.org/doc/06-config.md#preferred-install
@@ -49,11 +49,11 @@ Contributing | |||
|
|||
If you want to contribute to Neos and want to set up a development environment, then follow these steps: | |||
|
|||
``composer create-project neos/neos-development-distribution neos-development dev-master --keep-vcs`` | |||
``composer create-project neos/neos-development-distribution neos-development dev-master --keep-vcs --prefer-install=auto`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the --keep-vcs is no longer needed then right?
Or is this for legacy composer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is still needed (https://getcomposer.org/doc/03-cli.md#create-project) though I'm unsure how composer 2.x really behaves for source install. At least it's not stated in the CLI option that it directly correlates with prefer-install
Interesting, TIL. Shouldn't we explicitly use Edit: Can we maybe even just add those |
That would be the most comfortable ;) |
It has nothing to do with the
That's what I tried first, but it downloads everything as source then, even Symfony, Doctrine, … and it creates an error:
Only |
Oh, yes! I didn't even really read that section close enough–I thought it was about |
D'oh, I didn't know that! Then the old explanation was misleading anyway. Guess this is fine as a quick fix for now and let's check the composer.json preferred-install section in another PR? |
Created issues for the two *-dev-distributions and will merge this as is now :) |
When installing for development purposes,
--prefer-install=auto
needsto be used since Composer 2.1, see https://getcomposer.org/doc/06-config.md#preferred-install