Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Upgrade font awesome to version 5.15 #3391

Merged
merged 1 commit into from Aug 4, 2021

Conversation

markusguenther
Copy link
Member

With this PR we get news brand icons and covid-19 icons. Also some bugfixes related to unicode issues and much more.

See the changes here FortAwesome/Font-Awesome@5.12.1...5.15.3

What I did
Updated the font awesome resources and adjusted the paths to our needs.

How to verify it
Use a new Icon like head-side-mask.

Screenshot 2021-07-29 at 11 30 41

Releated: #3390

With this PR we get news brand icons and covid-19 icons. Also some bugfixes related to unicode  issues and much more.

See the changes here FortAwesome/Font-Awesome@5.12.1...5.15.3
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Wonder if we cannot get rid of the source files in the repo?

@markusguenther
Copy link
Member Author

Hmm as we now use webpack, that should be possible.
Then we would use the npm package and need to include the all.js.

Copy link
Member

@daniellienert daniellienert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @markusguenther

@Sebobo Sebobo merged commit 9207505 into neos:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants