Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Persist every 1000 iterations in media:clearthumbnails #3916

Merged
merged 1 commit into from Oct 25, 2022
Merged

TASK: Persist every 1000 iterations in media:clearthumbnails #3916

merged 1 commit into from Oct 25, 2022

Conversation

kdambekalns
Copy link
Member

@kdambekalns kdambekalns commented Oct 10, 2022 •
edited by jonnitto

This includes a few style tweaks as well, but the main part is the introduction
of persisting changes every 1000 iterations when clearing thumbnails.

This makes restarting possible without having lost (much) progress.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@kdambekalns
TASK: Persist every 1000 iterations in media:clearthumbnails
80edccd 
This includes a few style tweaks as well, but the main part is the introduction
 of persisting changes every 1000 iterations when clearing thumbnails.

This makes restarting possible without having lost (much) progress.
@kdambekalns kdambekalns self-assigned this Oct 10, 2022
@kdambekalns kdambekalns marked this pull request as ready for review October 10, 2022 22:29
jonnitto
jonnitto approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by reading

daniellienert
daniellienert approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@daniellienert daniellienert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by reading

@kdambekalns kdambekalns merged commit c2dfac9 into neos:8.2 Oct 25, 2022
@kdambekalns kdambekalns deleted the task/persist-during-clearthumbnails branch October 25, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellienert daniellienert daniellienert approved these changes

@jonnitto jonnitto jonnitto approved these changes

@robertlemke robertlemke Awaiting requested review from robertlemke

@Sebobo Sebobo Awaiting requested review from Sebobo

Assignees

@kdambekalns kdambekalns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdambekalns @daniellienert @jonnitto