BUGFIX: Cleanup media browser addFlashMessageTrait
#3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion add missing `htmlspecialchars`
6 tasks
mhsdesign
changed the title
crydotsnake
requested changes
Nov 1, 2022
Neos.Media.Browser/Classes/Controller/AddTranslatedFlashMessageTrait.php
Outdated
Show resolved
Hide resolved
Neos.Media.Browser/Classes/Controller/AddTranslatedFlashMessageTrait.php
Outdated
Show resolved
Hide resolved
crydotsnake
changed the title
mhsdesign
force-pushed
the
bugfix/3898-cleanup-media-browser-AddFlashMessageTrait
branch
from
bf26152
to
e75e98e
Compare
mhsdesign
changed the title
mhsdesign
changed the title
mhsdesign
changed the title
mhsdesign
changed the title
addFlashMessageTrait
|
TBH: I don't see a difference in the code (except for naming). Is there any? |
mhsdesign
commented
Nov 3, 2022
crydotsnake
approved these changes
Nov 12, 2022
|
Tested, and works! |
crydotsnake
deleted the
bugfix/3898-cleanup-media-browser-AddFlashMessageTrait
branch
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #3898
another fix for the problem, by refactoring the
AddFlashMessageTraitthanks @crydotsnake for the initial effort with #3940 but it if accepted it would make your approach obsolete. (I dindt wanted to force push on your branch - thus a new pr ^^)
see #3940 (comment) for the explanation of this fix
Upgrade instructions
Review instructions
Create a tag with
%sign and wait for the flashmessage:Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions