Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Have FlowQuery operations reliably detect nodes during canEvaluate #3946

Closed
wants to merge 16 commits into from
Closed

BUGFIX: Have FlowQuery operations reliably detect nodes during canEvaluate #3946

wants to merge 16 commits into from

Commits on Nov 2, 2022

  1. TASK: prevent first array element from being accessed via $context

    @crydotsnake @mhsdesign
    crydotsnake authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    e0fa10d View commit details
    Browse the repository at this point in the history

  2. TASK: fix styleci

    @crydotsnake @mhsdesign
    crydotsnake authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    7f7f71f View commit details
    Browse the repository at this point in the history

  3. TASK: switch to TraversableNodeInterface class in mockNode

    @crydotsnake @mhsdesign
    crydotsnake authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    8ca43bd View commit details
    Browse the repository at this point in the history

  4. TASK: set condition to default

    @crydotsnake @mhsdesign
    crydotsnake authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    2fb441d View commit details
    Browse the repository at this point in the history

  5. TASK: set conditions back to default

    @crydotsnake @mhsdesign
    crydotsnake authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    f99caa0 View commit details
    Browse the repository at this point in the history

  6. TASK: set conditions back to default

    @crydotsnake @mhsdesign
    crydotsnake authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    935db18 View commit details
    Browse the repository at this point in the history

  7. TASK: Centralize canEvaluate method in ContentRepository FlowQuery op… 

    …erations

The new implementation checks that the first item is a NodeInterface regardless wether
the array key is 0 or the item is inside a traversable.
    @mficzel @mhsdesign
    mficzel authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    b9233c2 View commit details
    Browse the repository at this point in the history

  8. TASK: Verify every item for find operation canEvaluate and remove unn… 

    …eeded use statements
    @mficzel @mhsdesign
    mficzel authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    3be6ae6 View commit details
    Browse the repository at this point in the history

  9. TASK: Adjust can evaluate method in flowQuery find operation 

    The check now make a distinction between the nodeInterface and the TraversableNodeInterface
    @mficzel @mhsdesign
    mficzel authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    dddd215 View commit details
    Browse the repository at this point in the history

  10. TASK: Exclude find from generic flowQuery operations test 

    This is needed because find operates on the old NodeInterface which is not compatible with the current mocks.
    @mficzel @mhsdesign
    mficzel authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    3fe49dc View commit details
    Browse the repository at this point in the history

  11. TASK: apply changes from styleci

    @crydotsnake @mhsdesign
    crydotsnake authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    5ea2c41 View commit details
    Browse the repository at this point in the history

  12. TASK: Add return types

    @mficzel @mhsdesign
    mficzel authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    938d8c5 View commit details
    Browse the repository at this point in the history

  13. TASK: Reapply: FlowQueryOperations fix some errors found by Doctum 

    Reapplies 928cc4a
As i oversaw those changes in a merge conflict
    @kdambekalns @mhsdesign
    kdambekalns authored and mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    3f13492 View commit details
    Browse the repository at this point in the history

  14. TASK: FlowQueryOperations fix error found by Doctum and cleanup doc c… 

    …omments
    @mhsdesign
    mhsdesign committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    fbe29aa View commit details
    Browse the repository at this point in the history

Commits on May 7, 2023

  1. TASK: cleanup

    @crydotsnake
    crydotsnake committed May 7, 2023
    Configuration menu
    Copy the full SHA
    9f20b83 View commit details
    Browse the repository at this point in the history

  2. TASK: apply suggestions from code review

    @crydotsnake
    crydotsnake committed May 7, 2023
    Configuration menu
    Copy the full SHA
    3fe0683 View commit details
    Browse the repository at this point in the history