Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Fix NULL content type error in ContentElementWrappingService #3969

Merged
merged 2 commits into from Dec 1, 2022
Merged

BUGFIX: Fix NULL content type error in ContentElementWrappingService #3969

merged 2 commits into from Dec 1, 2022

Conversation

kitsunet
Copy link
Member

@kitsunet kitsunet commented Dec 1, 2022

No description provided.

jonnitto
jonnitto approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by reading

markusguenther
markusguenther approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my project with that fix.

@kitsunet @Sebobo
Update Neos.Neos/Classes/Fusion/ContentElementWrappingImplementation.php
6b6cfd3 
Co-authored-by: Sebastian Helzle <sebastian@helzle.net>
kdambekalns
kdambekalns approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@kdambekalns
Copy link
Member

Q: Is only 8.2 affected?

@Sebobo
Copy link
Member

Sebobo commented Dec 1, 2022

Yes I broke it in my wrapping cleanup because I relied on the types in the docblocks

@kdambekalns kdambekalns merged commit 3d2ddf4 into neos:8.2 Dec 1, 2022
@markusguenther
Copy link
Member

Nice and thanks 💙

@markusguenther markusguenther mentioned this pull request Dec 1, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdambekalns kdambekalns kdambekalns approved these changes

@Sebobo Sebobo Sebobo approved these changes

@markusguenther markusguenther markusguenther approved these changes

@jonnitto jonnitto jonnitto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kitsunet @kdambekalns @Sebobo @markusguenther @jonnitto