Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: require php dom extension in Neos.Fusion #3987

Merged
merged 2 commits into from Jan 12, 2023
Merged

BUGFIX: require php dom extension in Neos.Fusion #3987

merged 2 commits into from Jan 12, 2023

Conversation

crydotsnake
Copy link
Member

@crydotsnake crydotsnake commented Dec 24, 2022 •
edited

Upgrade instructions

Review instructions

Resolves: #3964

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

grebaldi
grebaldi approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@grebaldi grebaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 by reading.

@crydotsnake crydotsnake changed the title BUGFIX: suggest php dom extension in Neos.Fusion BUGFIX: require php dom extension in Neos.Fusion Jan 12, 2023
@kdambekalns kdambekalns merged commit c43221b into neos:8.2 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdambekalns kdambekalns kdambekalns approved these changes

@grebaldi grebaldi grebaldi approved these changes

@mhsdesign mhsdesign Awaiting requested review from mhsdesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Neos.Fusion does not declare dependency on ext-dom
3 participants
@crydotsnake @kdambekalns @grebaldi