BUGFIX: Consistently initialize asset sources via createFromConfiguration

[grebaldi]

fixes: #3965

The Problem

The case at hand was an asset source that uses a value object to validate the incoming asset source options. I expected to be able to define a promoted constructor property with said value object as its declared type:

final class MyAssetSource implements AssetSourceInterface
{
    public function __construct(
        private readonly string $assetSourceIdentifier,
        private readonly Options $options
    ) {
    }

   /* ... */
}

...and initialize the value object in the createFromConfiguration static factory method defined by the AssetSourceInterface:

final class MyAssetSource implements AssetSourceInterface
{
   /* ... */

    public static function createFromConfiguration(string $assetSourceIdentifier, array $assetSourceOptions): AssetSourceInterface
    {
        return new static(
            $assetSourceIdentifier,
            Options::fromArray($assetSourceOptions)
        );
    }
}

This failed with a Type Error, because the AssetSourceService, which is responsible for initializing asset sources, at one point does not utilize createFromConfiguration to perform initialization, but calls the asset source constructor directly:

neos-development-collection/Neos.Media/Classes/Domain/Service/AssetSourceService.php

Line 178 in a4791b6

$this->assetSources[$assetSourceIdentifier] = new $assetSourceConfiguration['assetSource']($assetSourceIdentifier, $assetSourceConfiguration['assetSourceOptions'] ?? []);

The Solution

I adjusted the aforementioned routine of the AssetSourceService to use the AssetSourceInterface-defined createFromConfiguration static factory method instead of the asset source's constructor.

Even though the pattern I described above only makes sense in a PHP >8.0 environment, I decided to target Neos 7.3 with this PR, because it should constitute a non-breaking bugfix.

[bwaidelich]

+1 by reading

[Sebobo]

Looks fine by reading

[kdambekalns]

👍