Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Add php version declaration to neos/fusion-afx #4212

Merged
merged 1 commit into from Apr 26, 2023

Conversation

kitsunet
Copy link
Member

No description provided.

@Sebobo
Copy link
Member

Sebobo commented Apr 26, 2023

Shouldn't we in general make sure the version of this package matches the Neos version like we do with other packages?

@kitsunet
Copy link
Member Author

I don't see why we have to as long as the API doesn't change? But would be fine for me too I guess.

@kitsunet
Copy link
Member Author

I'd say lets merge this for now and consider how to deal with this in the future...

@Sebobo
Copy link
Member

Sebobo commented Apr 26, 2023

I mean when I work on this package I would at least assume that all other packages match and don't test it with Neos 7 separately when I work on 8.x f.e.

@kitsunet
Copy link
Member Author

@Sebobo yep, yep, agreed. We could add that as well on top. the question is, do we depend on fusion 8 or just let neos depend on the respective fusion-afx version, many options...

@kitsunet kitsunet merged commit 614b3fb into 8.3 Apr 26, 2023
6 checks passed
@kitsunet kitsunet deleted the kitsunet-patch-1 branch April 26, 2023 09:40
@markusguenther
Copy link
Member

Thanks for taking care @kitsunet 🥳

@Chxyz
Copy link

Chxyz commented Apr 26, 2023

Hi,
Thanks for that!

Just a question, shouldn't there be a commit in the 7.3 branch?
Since it's the 7.3 projects that are impacted by this... :-)

Best regards,
Chrys

@kitsunet
Copy link
Member Author

Hey Chrys,

well yes and no. I guess we have to add a fixed version requirement to fusion-afx in earlier branches, the php requirements won't really help though. I talked to karsten about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants