Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: add default value for generatorName at kickstart command in SiteKickstarter #4214

Merged
merged 1 commit into from Jun 27, 2023

Conversation

LvckyAPI
Copy link
Contributor

@LvckyAPI LvckyAPI commented Apr 29, 2023

We tried to reproduce #4053.
We can't reproduce this issue, but while reproducing we found a flow command prompt, without a default value.

The command flow kickstart:site AnySite.Site asks for a site generator.
We added a default value by adding:

array_key_first($selection)

Review instructions
At

array_key_last is used. Should we use array_key_last too or is array_key_first fine for it?

Checklist

  • Code follows the PSR-2 coding style
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 7.3 label Apr 29, 2023
@crydotsnake crydotsnake changed the title SiteKickstarter: add default value for generatorName at kickstart command BUGFIX: add default value for generatorName at kickstart command in SiteKickstarter Apr 29, 2023
@crydotsnake crydotsnake added Bug and removed Bug labels Apr 29, 2023
@crydotsnake crydotsnake changed the title BUGFIX: add default value for generatorName at kickstart command in SiteKickstarter TASK: add default value for generatorName at kickstart command in SiteKickstarter Apr 29, 2023
@github-actions github-actions bot added the Task label Apr 29, 2023
@LvckyAPI
Copy link
Contributor Author

Hey, can anyone tell me how long it needs to review a Pull request like this? :)

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait. We must have overseen your pr. But now i just tested the change and it works as expected.

previously there was no default value:

image

now there is one
image

and "enter" will directly go ahead and start the process

Thank you for your first contribution ;)

@mhsdesign mhsdesign merged commit 0d155a3 into neos:7.3 Jun 27, 2023
13 checks passed
@LvckyAPI LvckyAPI deleted the add-default-value-for-generatorName branch July 19, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants