TASK: add default value for generatorName at kickstart command in SiteKickstarter #4214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to reproduce #4053.
We can't reproduce this issue, but while reproducing we found a flow command prompt, without a default value.
The command
flow kickstart:site AnySite.Site
asks for a site generator.We added a default value by adding:
array_key_first($selection)
Review instructions
At
neos-development-collection/Neos.CliSetup/Classes/Command/SetupCommandController.php
Line 165 in 79dd4e1
array_key_last
is used. Should we usearray_key_last
too or isarray_key_first
fine for it?Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions