BUGFIX: Allow disabling of auto-created Image Variants #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes support for the setting `autoCreateImageVariantPresets` that was documented for a long time but never actually evaluated. This change set: * Adjusts `AssetService::assetCreated()` signal to only trigger `AssetVariantGenerator::createVariants()` if the `autoCreateImageVariantPresets` flag is set * Sets the default value of the flag to `true` for greater backwards compatibility * Adjusts `AssetVariantGenerator::createVariant()` to only create a variant if it does not exist already – previously multiple variants with the same identifiers could be created for a single asset leading to undeterministic behavior * Adds a button "Create missing Variants" to the `Variants` tab of the Media Module allowing editors to manually trigger creation of (missing) variants. Fixes: #4300
ahaeslich
approved these changes
May 30, 2023
lorenzulrich
approved these changes
May 31, 2023
|
@bwaidelich Thanks a lot, that's great to have. |
|
Hi ;) i just found this pr - were you able to test this @lorenzulrich and is this ready to be merged @bwaidelich - maybe we can include it in the upcoming bugfix release (today or tomorrow). |
|
Yes, this is good to go IITC |
bwaidelich
commented
Jul 12, 2023
bwaidelich
commented
Jul 12, 2023
Co-authored-by: Bastian Waidelich <b.waidelich@wwwision.de>
mhsdesign
deleted the
bugfix/4300-allow-disabling-of-autocreated-image-variants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes support for the setting
autoCreateImageVariantPresetsthat was documented for a long time but never actually evaluated.This change set:
AssetService::assetCreated()signal to only triggerAssetVariantGenerator::createVariants()if theautoCreateImageVariantPresetsflag is settruefor greater backwards compatibilityAssetVariantGenerator::createVariant()to only create a variant if it does not exist already – previously multiple variants with the same identifiers could be created for a single asset leading to undeterministic behaviorVariantstab of the Media Module allowing editors to manually trigger creation of (missing) variants.Fixes: #4300