Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Avoid potential deprecation warnings #4409

Merged
merged 1 commit into from Jul 18, 2023
Merged

TASK: Avoid potential deprecation warnings #4409

merged 1 commit into from Jul 18, 2023

Conversation

kdambekalns
Copy link
Member

trim() and preg_match() expect strings, but Eel with it's loose typing might pass in different types.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@kdambekalns
TASK: Avoid potential deprecation warnings
ab1bc3c 
`trim()` and `preg_match()` expect strings, but Eel with it's loose
typing might pass in different types.
@kdambekalns kdambekalns self-assigned this Jul 18, 2023
@kitsunet kitsunet merged commit 8c96f47 into neos:7.3 Jul 18, 2023
8 checks passed
@kdambekalns kdambekalns deleted the task/php-81-deprecations-compatibility branch September 28, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

@crydotsnake crydotsnake crydotsnake approved these changes

Assignees

@kdambekalns kdambekalns

Labels
7.3 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdambekalns @kitsunet @crydotsnake