Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: show title on hover in ImpersonateButton #4438

Merged
merged 1 commit into from Aug 18, 2023
Merged

BUGFIX: show title on hover in ImpersonateButton #4438

merged 1 commit into from Aug 18, 2023

Conversation

crydotsnake
Copy link
Member

@crydotsnake crydotsnake commented Aug 4, 2023 •
edited

Review instructions

Currently if you hovered over the button, the title was not showing up.

Since the Feature #3648 was introduced in Neos 8.0 I'm open this against the 8.0 Branch.

Demo

SCR-20230803-nhty

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

markusguenther
markusguenther approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crydotsnake, tested the change locally and it works 👍

@markusguenther markusguenther mentioned this pull request Aug 17, 2023
Draft
@markusguenther markusguenther merged commit fe13b0b into neos:8.0 Aug 18, 2023
6 checks passed
@markusguenther markusguenther mentioned this pull request Aug 18, 2023
Closed
@crydotsnake crydotsnake deleted the bugfix/hover-impersonate-button branch August 26, 2023 18:10
@crydotsnake crydotsnake restored the bugfix/hover-impersonate-button branch August 26, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusguenther markusguenther markusguenther approved these changes

Assignees
No one assigned
Labels
8.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crydotsnake @markusguenther