Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Refactor UI Validator translations to Neos.Neos.Ui package #4493

Draft
wants to merge 1 commit into
base: 9.0
Choose a base branch
from

Conversation

crydotsnake
Copy link
Member

@crydotsnake crydotsnake commented Sep 8, 2023

Upgrade instructions

This pull request refactors the translations for our Neos.Neos.Ui Validators in the Neos.Neos.Ui package.

Please try this pull request in combination with: neos/neos-ui#3614

Review instructions

Resolves: #4485

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@dlubitz
Copy link
Contributor

dlubitz commented Sep 11, 2023

I'm not sure about the removal of the keys in the non-EN files. If we add new keys, this is happen by weblate. Does it also handle the removals? 🤔 If we change it in the xlf files it might get lost during upmerges? (Not sure about that, as we do that in the highest branch)

Weblate is a topic here anyway. We should copy/move the translations also to the Neos.Ui node there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 Neos.Ui Neos Ui topics, that depend also on Neos adjustments Task
Projects
Status: Under Review 👀
Development

Successfully merging this pull request may close these issues.

TASK: Refactor translations of the Neos UI validators to the Neos UI
2 participants