Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: NodeMigration with target workspace #4685

Merged
merged 17 commits into from
Jun 25, 2024
Merged

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Nov 2, 2023

Overhaul node migrations to work with a target workspace and the ability to get the migrations immediately published after successful migration.

This was discussed on the Frankfurt Sprint. It changes the handling of node migrations back to a similar behavior as in Neos <9 and publishes changes of node migrations into the source branch immediately, but allows still to execute node migrations into reviewable workspaces.

  • "Submigrations" have been removed
  • Creates new workspace per migration(-file) ("migration-live-20231102123456")
  • Renaming of "workspace" to "sourceWorkspace"
  • Adds flag to publish targetWorkspace to sourceWorkspace after success ("publishOnSuccess", default: true)
  • Removes content stream ids from outside
  • Adopted Behat Tests

Fixes #4442

@dlubitz dlubitz force-pushed the 90/feature/nodemigration branch 2 times, most recently from 118e534 to 9d28e6e Compare November 3, 2023 15:43
@dlubitz dlubitz linked an issue Nov 12, 2023 that may be closed by this pull request
3 tasks
@dlubitz dlubitz self-assigned this Nov 12, 2023
@dlubitz dlubitz marked this pull request as ready for review May 12, 2024 20:45
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was not part of the discussions at the frankfurt sprint so im not sure i really understand will have to sync with you or try this out ^^

id favor a review from someone you discussed this with

@dlubitz
Copy link
Contributor Author

dlubitz commented May 13, 2024

Even if I'm sure you attended that discussion 😜 I'm happy to sync.

Consent was actually to get it working similar to the node migration in Neos <9, because the previous version (in Neos 9) did not and keep a bit of flexibility to execute node migrations in branches for reviewing.

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the adjustments 💖

@dlubitz
Copy link
Contributor Author

dlubitz commented Jun 14, 2024

@nezaniel Would be great to get your approval here, to get this merged. 🙏

@kitsunet kitsunet merged commit f7e93b0 into 9.0 Jun 25, 2024
10 checks passed
@kitsunet kitsunet deleted the 90/feature/nodemigration branch June 25, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Node Migrations
4 participants