TASK: Add tests for FlowQuery nextUntil, prevUntil, siblings and find
#4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mficzel
force-pushed
the
task/addBehatTestsForFlowQueryCrOperations
branch
from
c796cae
to
4854053
Compare
mficzel
changed the title
nextUntil, prevUntil and siblingsnextUntil, prevUntil, siblings and find
mhsdesign
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
I ran the tests also locally and it looks perfect. I can also confirm that the ci picks up this newer feature file automatically (wasnt sure about globbing). As the tests are a bit hard to read - one needs to put the node tree in memory ^^- i only checked the Find scenario but can confirm it tests what is expected.
|
I recommend to use the ide Split View for comparing testcase and ci content 🙃 |
ahaeslich
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests of
nextUntil,prevUntil,siblingsandfindthat were still missing.Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions