Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Use role label in list users/new user view if available #4793

Merged
merged 1 commit into from Dec 4, 2023

Conversation

lorenzulrich
Copy link
Contributor

In Neos 7 (and with neos/flow-development-collection#2162), role labels were introduced. While we now have a nice table view in the "edit account" view, the role label is not displayed anywhere else.

I'm aware that Neos 7 and 8 are in maintenance-only mode, but I think we all agree that Neos 8 will be around for quite a while. I suggest the minimal change to use the role label in the user list and the "new user" view if there is one.

  • [N/A] Code follows the PSR-2 coding style
  • [N/A] Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • [N/A] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@kitsunet
Copy link
Member

kitsunet commented Dec 4, 2023

I like it and wouldn't mind having that

@kdambekalns kdambekalns merged commit 5fd80d6 into neos:7.3 Dec 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants