Commits on Jan 24, 2024

1. TASK: Migrate Neos.Fusion/Core to phpstan level 8 (Neos 8.3) …

   Only files in `Neos.Fusion/Classes/Core` have been migrated, as they contain relatively new code like the parser.
   
   Two kind of errors have been partially ignored from the level 8
   
   For one: "no value type specified in iterable type array" as adding `array<int|string, mixed>` would just bloat this commit up. In these files we are mostly dealing with the fusion configuration which is highly dynamic:
   
   - Neos.Fusion/Classes/Core/Runtime.php
   - Neos.Fusion/Classes/Core/Cache/RuntimeContentCache.php
   - Neos.Fusion/Classes/Core/Cache/ContentCache.php
   - Neos.Fusion/Classes/Core/Cache/CacheSegmentParser.php
   - Neos.Fusion/Classes/Core/RuntimeConfiguration.php
   - Neos.Fusion/Classes/Core/ObjectTreeParser/MergedArrayTreeVisitor.php
   - Neos.Fusion/Classes/Core/ObjectTreeParser/MergedArrayTree.php
   
   And "has no return type specified" was noticed a lot in the ast visiting code. But i plan to refactor this instead to something better type able:
   
   - Neos.Fusion/Classes/Core/ObjectTreeParser/MergedArrayTreeVisitor.php
   - Neos.Fusion/Classes/Core/ObjectTreeParser/AstNodeVisitorInterface.php
   - Neos.Fusion/Classes/Core/ObjectTreeParser/Ast

   

   mhsdesign committed Jan 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for d0377b9
   • Browse repository at this point

   Copy the full SHA

   d0377b9 View commit details

   Browse the repository at this point in the history