Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Allow dimension preset keys to be different from values for DimensionsMenu #4859

Merged
merged 2 commits into from
Feb 23, 2024
Merged

BUGFIX: Allow dimension preset keys to be different from values for DimensionsMenu #4859

merged 2 commits into from
Feb 23, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Jan 30, 2024 •
edited by kdambekalns
Loading

This removes the implicit convention that dimensionPresetKey must be the same as the dimensionValue.

Review instructions

Fixes #4857

@dlubitz dlubitz self-assigned this Jan 30, 2024
mhsdesign
mhsdesign approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fine by reading.

Neos.Neos/Classes/Fusion/DimensionsMenuItemsImplementation.php Show resolved Hide resolved
@mhsdesign
Copy link
Member

Last call for reviews :P

kdambekalns
kdambekalns approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by reading…

@dlubitz dlubitz merged commit 56841ac into neos:8.3 Feb 23, 2024
8 checks passed
@dlubitz dlubitz deleted the bugfix/dimension-value-independent branch February 23, 2024 10:44
@mhsdesign
Copy link
Member

@dlubitz i assume that is not a problem in 9.0, i will at least discard your changed in the DimensionsMenuItemsImplementation when up-merging as it totally changed

@dlubitz dlubitz mentioned this pull request May 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdambekalns kdambekalns kdambekalns approved these changes

@mhsdesign mhsdesign mhsdesign approved these changes

Assignees

@dlubitz dlubitz

Labels
8.3 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dlubitz @mhsdesign @kdambekalns