BUGFIX: Prevent cache overflow when querying nodes by related entities #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change new cache entries in Flow_Persistence_Doctrine are generated for each entry in the relationMap causing massive slowdowns in Neos f.e. when many assets are deleted as the file system cache cannot handle large numbers of entries well. With this change only one entry per number of relations is generated which is usually only a few and the entries can be reused. Resolves: #4876
kitsunet
reviewed
Feb 7, 2024
| @@ -1710,24 +1710,29 @@ protected function buildQueryBuilderForRelationMap($relationMap) | |||
| $constraints = []; | |||
| $parameters = []; | |||
|
|
|||
| // Use a counter to avoid parameter name conflicts and limit query metadata cache entries to the maximum number of relations | |||
| $identifierIndex = 0; | |||
|
|
|||
| foreach ($relationMap as $relatedObjectType => $relatedIdentifiers) { | |||
| foreach ($relatedIdentifiers as $relatedIdentifier) { | |||
There was a problem hiding this comment.
you could probably just use the array key from here? but I guess fine for now.
There was a problem hiding this comment.
Don't think so, as we have two loops.
kitsunet
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change new cache entries in Flow_Persistence_Doctrine are generated for each entry in the relationMap causing massive slowdowns in Neos f.e. when many assets are deleted as the file system cache cannot handle large numbers of entries well.
With this change only one entry per number of relations is generated which is usually only a few and the entries can be reused.
Resolves: #4876