Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Allow to disable projection or catchUpHook in config #4904

Merged
merged 1 commit into from
Feb 23, 2024
Merged

TASK: Allow to disable projection or catchUpHook in config #4904

merged 1 commit into from
Feb 23, 2024

Conversation

mhsdesign
Copy link
Member

Resolves: #4878

by setting it to null or ~

That for example allows to speed up local e2e tests by diabling certain neos specific projections:

Neos:
  ContentRepositoryRegistry:
    presets:
      'default':
        projections:
          'Neos.Neos:DocumentUriPathProjection':
            catchUpHooks:
              'Neos.Neos:FlushRouteCache': ~
          'Neos.Neos:PendingChangesProjection': ~
          'Neos.ContentRepository:ContentGraph':
            catchUpHooks:
              'Neos.Neos:FlushContentCache': ~
          'Neos.Neos:AssetUsage': ~

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
TASK: Allow to disable projection or catchUpHook in config
02105e3 
Resolves: neos#4878

by setting it to null or `~`

That for example allows to speed up local e2e tests by diabling certain neos specific projections:

```yaml
Neos:
  ContentRepositoryRegistry:
    presets:
      'default':
        projections:
          'Neos.Neos:DocumentUriPathProjection':
            catchUpHooks:
              'Neos.Neos:FlushRouteCache': ~
          'Neos.Neos:PendingChangesProjection': ~
          'Neos.ContentRepository:ContentGraph':
            catchUpHooks:
              'Neos.Neos:FlushContentCache': ~
          'Neos.Neos:AssetUsage': ~
```
@mhsdesign mhsdesign mentioned this pull request Feb 20, 2024
Closed
skurfuerst
skurfuerst approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me :)

@kitsunet kitsunet merged commit e334436 into neos:9.0 Feb 23, 2024
9 checks passed
@mhsdesign mhsdesign deleted the task/4878-speedup-test-locally branch February 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skurfuerst skurfuerst skurfuerst approved these changes

@kitsunet kitsunet kitsunet approved these changes

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance ESCR tests. Disabling Neos.Neos catchUpHooks speeds up tests
3 participants
@mhsdesign @skurfuerst @kitsunet