Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Fix propertyValueCriteriaMatcherTest #4926

Merged
merged 1 commit into from
Mar 11, 2024
Merged

BUGFIX: Fix propertyValueCriteriaMatcherTest #4926

merged 1 commit into from
Mar 11, 2024

Conversation

mficzel
Copy link
Member

@mficzel mficzel commented Mar 11, 2024 •
edited
Loading

The constructor of SerializedPropertyValue has been declared abstract.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mficzel mficzel marked this pull request as ready for review March 11, 2024 11:10
@ahaeslich ahaeslich merged commit 65bff1f into neos:9.0 Mar 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahaeslich ahaeslich ahaeslich approved these changes

@mhsdesign mhsdesign Awaiting requested review from mhsdesign

@kitsunet kitsunet Awaiting requested review from kitsunet

Assignees
No one assigned
Labels
9.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mficzel @ahaeslich