Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Enforce unique names also for root children #4982

Merged
merged 2 commits into from Apr 25, 2024

Conversation

nezaniel
Copy link
Member

@nezaniel nezaniel commented Apr 6, 2024

Until now, we checked uniqueness for node names for an explicitly given origin of the parent.
While this makes sense in general, the constraint checks fails for more than zero dimensions when the parent is a root node, because root nodes still have a zero dimensional origin which then is not properly checked.

Upgrade instructions

None

Review instructions

None

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Apr 6, 2024
@nezaniel nezaniel requested review from skurfuerst, bwaidelich, ahaeslich and kitsunet and removed request for skurfuerst April 6, 2024 21:25
@mhsdesign mhsdesign self-requested a review April 19, 2024 09:04
@mhsdesign mhsdesign changed the title Enforce unique names also for root children BUGFIX: Enforce unique names also for root children Apr 25, 2024
@github-actions github-actions bot added the Bug label Apr 25, 2024
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by reading and i also experimented with the testcase locally a bit and it failed previously.

@nezaniel nezaniel merged commit dab3d0b into 9.0 Apr 25, 2024
11 checks passed
@nezaniel nezaniel deleted the uniqueNamesForRootChildren branch April 25, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants