Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove explicit deprecated command blocking #5059

Merged
merged 4 commits into from
May 17, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented May 17, 2024

This change was partially ported from #4988

Following things have been adjusted:

  • Removal of the step: The graph projection is fully up to date
    • remove lastCommandOrEventResult
  • Removal of the step: The documenturipath projection is up to date
  • Remove CommandResult::block in php

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

This change was partially ported from neos#4988

Following things have been adjusted:

- Removal of the step: The graph projection is fully up to date
  - remove lastCommandOrEventResult
- Removal of the step: The documenturipath projection is up to date
- Use injected Connection in tests instead of DoctrineDbalClient (this will be fully refactored in neos#4988)
@mhsdesign mhsdesign force-pushed the task/removeExplicitDeprecatedBlocking branch from aea4ff0 to bba472b Compare May 17, 2024 11:58
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by 👁️ (with only one eye!)

@kitsunet
Copy link
Member

kitsunet commented May 17, 2024

Use injected Connection in tests instead of DoctrineDbalClient

This is super unrelated :/

@bwaidelich
Copy link
Member

This is super unrelated :/

yes. I agree  - and it was somehow unrelated in my large PR, too..
It would be cool if we could split that from this PR, but...

@mhsdesign
Copy link
Member Author

yes thats the only part that bums me as well but @bwaidelich started it in his pr and this is a partial git checkout -- from it ...

fyi. I did a review myself and can confirm that only the stuff that needed to has been removed from the .feature files.

@mhsdesign mhsdesign marked this pull request as draft May 17, 2024 12:38
@mhsdesign
Copy link
Member Author

aggreed did a little wizardy by manually editing a patch (tell me if there is a better way ^^) and reverted it 1to1. Should be imo part of #5005

836781b can be reverted then ;)

@mhsdesign mhsdesign marked this pull request as ready for review May 17, 2024 12:43
@kitsunet
Copy link
Member

DbalClientInterface seems missing according to the failings?

@mhsdesign mhsdesign force-pushed the task/removeExplicitDeprecatedBlocking branch from 836781b to 0df9079 Compare May 17, 2024 13:12
@mhsdesign
Copy link
Member Author

Missing import and no phpstan coverage :D

@mhsdesign mhsdesign merged commit 2914f11 into neos:9.0 May 17, 2024
9 checks passed
@mhsdesign mhsdesign deleted the task/removeExplicitDeprecatedBlocking branch May 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants