FEATURE: Use data source to list forms in inspector

[daniellienert]

Currently form identifiers need to be defined manually extending
the properties of TYPO3.Neos.NodeTypes:Form .
This change adds a data source which uses the
TYPO3\Form\Persistence\YamlPersistenceManager::listForms
to list all available forms automatically.

[mention-bot]

By analyzing the blame information on this pull request, we identified @daKmoR, @skurfuerst and @aertmann to be potential reviewers

[aertmann]

nice improvement 👍

[aertmann]

this could potentially expose form identifiers you don't want to expose though

also it doesn't conflict with existing configuration of the old behavior right?

[skurfuerst]

Very nice from my side -- looks very good! 👍

All the best, Sebastian

[daniellienert]

@aertmann: You're right, the data source overwrites the manual configuration. This means, it would expose existing, but not yet made accessible forms to the editor. I didn't encounter any other conflicts.
So should this change somehow be marked as breaking / behavior changing?

[aertmann]

@daniellienert: okay thanks for checking, I'd say that it's not really breaking since existing forms should still work, it's just that there could be some extra forms available. Thus I think it's fine not to mark it.

However the documentation needs to be adjusted http://neos.readthedocs.io/en/stable/HowTos/AddingSimpleContactForm.html

Also could make sense to describe that dataSourceIdentifier can be unset and the values configured manually if preferred.

[daniellienert]

@aertmann thanks for reminding me of the documentation. I removed the section about the node type configuration.

[dfeyer]

Nice one 👍

[kitsunet]

Just had someone in chat say that this was a breaking change for them. As it touches configuration it stricly is always a breaking change... I guess we need to get stricter on this.