New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Align displaced expand icons in node tree #587

Merged

kitsunet merged 1 commit into neos:2.2 from gerhard-boden:fix-displaced-expander-icons-2-2

Jun 29, 2016

Contributor

gerhard-boden commented Jun 19, 2016 •

edited

The expand icons in the node tree where off a few pixels along the y-axis (open and folded).

NEOS-1844 #close


          BUGFIX: Align displaced expand icons in node tree

c05650e

Contributor Author

gerhard-boden commented Jun 19, 2016

This bug was introduced with this PR:
#351

The reason is that Font Awesome sets the line-height in their mixin with the variable fa-line-height-base, but this seems to be a fixed value and nothing that can be passed to the mixin. When we need different line-heights like in this case, we have to (re)set them accordingly after the usage of this mixin.
https://github.com/neos/neos-development-collection/blob/master/TYPO3.Neos/Resources/Public/Library/fontawesome/scss/_mixins.scss#L6

Keep an eye out for other icons that stand out, might be the same problem as here.

daniellienert added P: Neos T: UX labels

kitsunet merged commit 9df6079 into neos:2.2

gerhard-boden deleted the fix-displaced-expander-icons-2-2 branch

July 2, 2016 21:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment