!!! FEATURE: Configurable Fusion node type prototype generators #767

mficzel · 2016-09-21T09:21:54Z

If fusion.prototypeGenerator is set to a className the class has to implement the interface
\TYPO3\Neos\Domain\Service\DefaultPrototypeGeneratorInterface and is used to generate the prototype-code
for this node.
If fusion.prototypeGenerator is set to null no prototype is created for this type.

For nodeTypes based on TYPO3.Neos:Node, TYPO3.Neos:Document or TYPO3.Neos:Content a backwards compatible implementation is added to the configuration and a new prototype generator for TYPO3.Neos:Plugin is added.

mention-bot · 2016-09-21T09:21:55Z

@mficzel, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dfeyer, @radmiraal and @kdambekalns to be potential reviewers

kitsunet · 2016-09-21T09:23:27Z

I like. Would also allow us to add a plugin generator as that is always wrong :)

mficzel · 2016-09-21T09:29:39Z

@kitsunet ... i'm impressed, you were almost faster then the mention bot.

What exactly should be added to the defaultPlugin Prototypes? I do'nt use it that often.

aertmann · 2016-09-21T13:51:25Z

TYPO3.Neos/Documentation/CreatingASite/NodeTypes/NodeTypeDefinition.rst

+        templatePath = 'resource://Vendor.Site/Private/Templates/NodeTypes/Content.SpecialNodeType.html'
+
+        # all properties of the nodeType are passed to the template
+        date =  ${q(node).property('date)}


double space

..and missing closing single quote

aertmann · 2016-09-21T13:52:02Z

TYPO3.Neos/Documentation/CreatingASite/NodeTypes/NodeTypeDefinition.rst

+
+    By default Neos has generators for all nodes of type TYPO3.Neos:Node and creates protoypes based on
+    TYPO3.TypoScript:Template. A template path is assumed based on the package-prefix and the nodetype-name. All properties
+    of the node are passed to the template. For nodeTypes of type TYPO3.Neos:Document or TYPO3.Neos:Content the


nodetype names should be quoted..

aertmann · 2016-09-21T13:52:05Z

TYPO3.Neos/Documentation/CreatingASite/NodeTypes/NodeTypeDefinition.rst

+    If ``options.fusionPrototypeGenerator`` is set to ``null`` no prototype is created for this type.
+
+    By default Neos has generators for all nodes of type TYPO3.Neos:Node and creates protoypes based on
+    TYPO3.TypoScript:Template. A template path is assumed based on the package-prefix and the nodetype-name. All properties


nodetype names should be quoted with ``

aertmann · 2016-09-21T13:53:19Z

TYPO3.Neos/Configuration/NodeTypes.yaml

@@ -2,6 +2,8 @@
 'TYPO3.Neos:Node':
  label: "${String.cropAtWord(String.trim(String.stripTags(String.pregReplace(q(node).property('title') || q(node).property('text') || ((I18n.translate(node.nodeType.label) || node.nodeType.name) + (node.autoCreated ? ' (' + node.name + ')' : '')), '/<br\\W*?\\/?>|\\x{00a0}|[[^:print:]]|\\s+/u', ' '))), 100, '...')}"
  abstract: TRUE
+  options:
+    fusionPrototypeGenerator: TYPO3\Neos\Domain\Service\DefaultPrototypeGenerator


I'm debating if the key options is a good idea here.. options is pretty broad and all of this configuration is somehow options.. would a key like fusion and then prototypeGenerator on next level make more sense?

aertmann · 2016-09-21T19:07:02Z

btw. what to do about the existing interface overriding? that would stop working as expected right? if so this is a breaking change..

aertmann · 2016-09-21T19:08:01Z

@skurfuerst @bwaidelich maybe you guys have input to this one (continued from thread)..

bwaidelich · 2016-09-21T20:07:31Z

yes, I like @aertmann s idea to use "fusion" as entry point and we already do that for the Neos UI with "ui"

mficzel · 2016-09-22T07:18:00Z

I adjusted the option name to fusion.prototypeGeneratorClassName, updated the documentation and added a Plugin Prototype Generator.

@aertmann this is somehow breaking but it will only go to 3.0 anyways.

dimaip · 2016-09-22T12:32:38Z

@aertmann I think it would be better to make this breaking than to keep the two mechanisms. I doubt many people already use that feature anyways.

dimaip · 2016-09-22T12:33:57Z

prototypeGeneratorClassName is very verbose though, any chances of making it shorter, e.g. prototypeGenerator? Wdyt?

mficzel · 2016-09-22T13:11:51Z

Renamed the option to fusion.prototypeGenerator

aertmann · 2016-09-22T20:11:05Z

looks great! nice one

dimaip · 2016-09-30T11:10:46Z

Can we already merge this stuff into master now, or only after we branch off 3.0?
If it's possible to do it now, the PR needs to be rebased and I'll review it.

aertmann · 2016-09-30T11:53:02Z

it's fine to merge breaking stuff for next major into master now

johannessteu · 2016-09-30T11:54:33Z

Yeah, also branching will be done not soonish

mficzel · 2016-09-30T16:13:25Z

I rebased the pr ... seems something broke by doing so. Will check the next days

mficzel · 2016-10-02T16:34:53Z

I cannot reproduce the failing tests locally. Unit and functional tests are running fine. Also the error looks kind of unrelated to this change.

mficzel · 2016-10-04T12:36:28Z

The errors were introduced in master with b2a1b0f and are not caused by this pr. I will rebase again as soon as the master is green again.

mficzel · 2016-10-06T11:44:55Z

Finally the tests are green again ...

kitsunet

The requested change makes a lot of small detail changes necessary in the NodeTypes configuration we have so far and in the generator, but I think it's for the better in terms of maintainability.

kitsunet · 2016-10-27T00:24:58Z

TYPO3.TYPO3CR/Resources/Private/Schema/NodeTypes.schema.yaml

@@ -75,6 +75,10 @@ additionalProperties:
    'options':
      type: dictionary

+    'fusion':


I was almost about to merge this, but this IMHO cannot happen, it implicitly binds CR to Fusion, which it shouldn't be. SORRY :/

The configuration should go under "options" and not be mentioned in this schema.

I agree to your point but TBH I don't think it's a better solution to "hide" this defacto dependency within some option that is not part of the schema.
IMO a good solution would be: extensible schemas. That would allow the Neos or Fusion package to add this option to the NodeTypes schema. And we could use this for other parts, too.
It shouldn't be to hard to adjust the SchemaValidator accordingly. In fact, it might already be able to do that.

Right, but I thought options was the current way to make this schema extensible?
So Neos can declare the fusion subkey in options and all currently possible subkeys of fusion.

The key was renamed to options.fusion.prototypeGenerator as requested

kitsunet · 2016-10-27T00:26:10Z

TYPO3.Neos/Documentation/CreatingASite/NodeTypes/NodeTypeDefinition.rst

@@ -119,6 +119,32 @@ The following options are allowed:
    Alternatively the class of a node label generator implementing
    ``TYPO3\TYPO3CR\Domain\Model\NodeLabelGeneratorInterface`` can be specified as a nested option.

+``fusion``


The below mentioned request to change the way the configuration is setup obviously makes a change here necessary.

mficzel · 2016-11-07T08:30:25Z

Ranamed the configuration property to options.fusion.prototypeGenerator as requested by @kitsunet and rebased on current master ... no clue why travis complains on postgres now ... will look into this later

kitsunet · 2016-11-07T09:06:21Z

Thanks! Looks great. The Travis failure is not related, it's the timezone issue fixed by this PR (which is not yet upmerged) #1214

- If ``fusion.prototypeGenerator`` is set to a className the class has to implement the interface ``\TYPO3\Neos\Domain\Service\DefaultPrototypeGeneratorInterface`` and is used to generate the prototype-code for this node. - If ``fusion.prototypeGenerator`` is set to ``null`` no prototype is created for this type. For nodeTypes based on ``TYPO3.Neos:Node``, ``TYPO3.Neos:Document`` or ``TYPO3.Neos:Content`` a backwards compatible implementation is added to the configuration and a new prototype generator for ``TYPO3.Neos:Plugin`` is added.

… to ``options.fusion.prototypeGeneratorPath``

mficzel · 2016-11-12T11:11:23Z

I rebased on current master to get rid of the ci-failures. No changes other than that.

mficzel added P: Content Repository P: Fusion P: Neos T: PHP T: Fusion labels Sep 21, 2016

aertmann reviewed Sep 21, 2016

View reviewed changes

mficzel force-pushed the feature/makeFusionPrototypeGeneratorConfigurable branch from fc62aad to 943cc42 Compare September 22, 2016 07:12

mficzel changed the title ~~FEATURE: Add option options.fusionPrototypeGenerator for nodeTypes~~ !!! FEATURE: Add option fusion.prototypeGeneratorClassName for nodeTypes Sep 22, 2016

mficzel added the !!! Next major label Sep 22, 2016

mficzel force-pushed the feature/makeFusionPrototypeGeneratorConfigurable branch from 943cc42 to 7cde216 Compare September 22, 2016 13:11

mficzel changed the title ~~!!! FEATURE: Add option fusion.prototypeGeneratorClassName for nodeTypes~~ !!! FEATURE: Add option fusion.prototypeGenerator for nodeTypes Sep 22, 2016

aertmann changed the title ~~!!! FEATURE: Add option fusion.prototypeGenerator for nodeTypes~~ !!! FEATURE: Configurable Fusion node type prototype generators Sep 22, 2016

mficzel force-pushed the feature/makeFusionPrototypeGeneratorConfigurable branch from 7cde216 to 532d85c Compare September 30, 2016 16:13

kitsunet requested changes Oct 27, 2016

View reviewed changes

kitsunet approved these changes Nov 7, 2016

View reviewed changes

mficzel added 2 commits November 12, 2016 12:09

TASK: Rename configuration key from fusion.prototypeGeneratorPath…

af39048

… to ``options.fusion.prototypeGeneratorPath``

mficzel force-pushed the feature/makeFusionPrototypeGeneratorConfigurable branch from 9222187 to af39048 Compare November 12, 2016 11:10

mficzel assigned gerhard-boden Nov 23, 2016

BUGFIX: Update path to ObjectManagerInterface

89dfdc5

gerhard-boden approved these changes Nov 23, 2016

View reviewed changes

gerhard-boden removed their assignment Nov 23, 2016

mficzel merged commit e431b85 into neos:master Nov 23, 2016

mficzel mentioned this pull request Nov 24, 2016

TASK: Add tests for FusionService::generateFusionForNodeType #1248

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

!!! FEATURE: Configurable Fusion node type prototype generators #767

!!! FEATURE: Configurable Fusion node type prototype generators #767

mficzel commented Sep 21, 2016 •

edited

mention-bot commented Sep 21, 2016

kitsunet commented Sep 21, 2016

mficzel commented Sep 21, 2016

aertmann Sep 21, 2016

bwaidelich Sep 21, 2016

aertmann Sep 21, 2016 •

edited

aertmann Sep 21, 2016 •

edited

aertmann Sep 21, 2016

aertmann commented Sep 21, 2016

aertmann commented Sep 21, 2016

bwaidelich commented Sep 21, 2016

mficzel commented Sep 22, 2016

dimaip commented Sep 22, 2016

dimaip commented Sep 22, 2016 •

edited

mficzel commented Sep 22, 2016 •

edited

aertmann commented Sep 22, 2016

dimaip commented Sep 30, 2016

aertmann commented Sep 30, 2016

johannessteu commented Sep 30, 2016

mficzel commented Sep 30, 2016 •

edited

mficzel commented Oct 2, 2016

mficzel commented Oct 4, 2016

mficzel commented Oct 6, 2016

kitsunet left a comment

kitsunet Oct 27, 2016

bwaidelich Oct 27, 2016 •

edited

kitsunet Oct 27, 2016

mficzel Nov 7, 2016

kitsunet Oct 27, 2016

mficzel commented Nov 7, 2016

kitsunet commented Nov 7, 2016

mficzel commented Nov 12, 2016

!!! FEATURE: Configurable Fusion node type prototype generators #767

!!! FEATURE: Configurable Fusion node type prototype generators #767

Conversation

mficzel commented Sep 21, 2016 • edited

mention-bot commented Sep 21, 2016

kitsunet commented Sep 21, 2016

mficzel commented Sep 21, 2016

aertmann Sep 21, 2016

Choose a reason for hiding this comment

bwaidelich Sep 21, 2016

Choose a reason for hiding this comment

aertmann Sep 21, 2016 • edited

Choose a reason for hiding this comment

aertmann Sep 21, 2016 • edited

Choose a reason for hiding this comment

aertmann Sep 21, 2016

Choose a reason for hiding this comment

aertmann commented Sep 21, 2016

aertmann commented Sep 21, 2016

bwaidelich commented Sep 21, 2016

mficzel commented Sep 22, 2016

dimaip commented Sep 22, 2016

dimaip commented Sep 22, 2016 • edited

mficzel commented Sep 22, 2016 • edited

aertmann commented Sep 22, 2016

dimaip commented Sep 30, 2016

aertmann commented Sep 30, 2016

johannessteu commented Sep 30, 2016

mficzel commented Sep 30, 2016 • edited

mficzel commented Oct 2, 2016

mficzel commented Oct 4, 2016

mficzel commented Oct 6, 2016

kitsunet left a comment

Choose a reason for hiding this comment

kitsunet Oct 27, 2016

Choose a reason for hiding this comment

bwaidelich Oct 27, 2016 • edited

Choose a reason for hiding this comment

kitsunet Oct 27, 2016

Choose a reason for hiding this comment

mficzel Nov 7, 2016

Choose a reason for hiding this comment

kitsunet Oct 27, 2016

Choose a reason for hiding this comment

mficzel commented Nov 7, 2016

kitsunet commented Nov 7, 2016

mficzel commented Nov 12, 2016

mficzel commented Sep 21, 2016 •

edited

aertmann Sep 21, 2016 •

edited

aertmann Sep 21, 2016 •

edited

dimaip commented Sep 22, 2016 •

edited

mficzel commented Sep 22, 2016 •

edited

mficzel commented Sep 30, 2016 •

edited

bwaidelich Oct 27, 2016 •

edited