Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Benchmark basics #105

Merged
merged 2 commits into from
Jun 10, 2024
Merged

TASK: Benchmark basics #105

merged 2 commits into from
Jun 10, 2024

Conversation

kitsunet
Copy link
Member

@kitsunet kitsunet commented Jun 7, 2024

Introduces a phpbench.json with configuration for phpbench and a composer script to execute the benchmarks.

PhpBench is to be installed via phive install phpbench

Relates: neos/flow-development-collection#3361
Relates: neos/BuildEssentials#71

Introduces a phpbench.json with configuration
for phpbench and a composer script to execute
the benchmarks.

PhpBench is to be installed via phive

phive install phpbench
@kitsunet
Copy link
Member Author

kitsunet commented Jun 7, 2024

We could also put the phpbench.json into the BuildEssentials.... Matter of choice really. I wouldn't mind either way. Any opionions.

@kitsunet
Copy link
Member Author

kitsunet commented Jun 7, 2024

Unfortunately using the config option for phpbench doesn't seem to work with relative paths?!? So moving it out is not feasible as we cannot know the absolute path (which does work). But renamed to phpbench.json.dist as that is taken as fallback and makes more sense. Also I just realized I need to make the same change in the flow-dev-distribution.... But for now Neos is a good starting point...

@kitsunet kitsunet merged commit 59d1b21 into neos:9.0 Jun 10, 2024
@kdambekalns
Copy link
Member

What is phive? Ah: https://phar.io/ (and some more details at https://php.watch/articles/phive)

Why that? Why not via composer?

@kitsunet
Copy link
Member Author

I do not want the dependency in the project, it makes no sense for tools like this IMHO. All build tools should rather come as phar to be independent of the codebase. Although phive has it#s problems (mainly missing maintenance atm). But I would still suggest ot anyone to install this as phar. But sure we can still decide to add it as require-dev in the future

@kdambekalns
Copy link
Member

All build tools should rather come as phar to be independent of the codebase.

In theory yes, in practice that caused problems in the past, whenever you had differences in PHP versions e.g. that broke things. Seeing that phive supports multiple / specific versions that might be a solution, though.

I was just a bit surprised, had never heard of the tool and wonder if we need to add some pointers or hints to some documentation?

@ahaeslich
Copy link
Member

and wonder if we need to add some pointers or hints to some documentation?

@kitsunet and I discussed this briefly and wondered where a good place would be for this.

@kdambekalns
Copy link
Member

and wonder if we need to add some pointers or hints to some documentation?

@kitsunet and I discussed this briefly and wondered where a good place would be for this.

We could add it CONTRIBUTING.md… after this is merged: neos/neos-development-collection#5137 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants