Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Prefer installing of neos and flowpack packages from source #72

Merged
merged 2 commits into from
Aug 18, 2021

Conversation

mficzel
Copy link
Member

@mficzel mficzel commented Aug 16, 2021

Since this is the development distribution for neos composer should install all neos packages from source.

Since quite some packages in the flowpack namespace are maintained by neos team members and some are
even installed in a default neos it makes our life easier to install packages from source in the development distribution aswell.

See https://getcomposer.org/doc/06-config.md#preferred-install

Resolves: #70

Since this is the development collection for neos composer should install all neos packages from source.

See https://getcomposer.org/doc/06-config.md#preferred-install
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is pretty specific, I usually want dev versions of Flowpack or other packages downloaded as source, too. I'd personally prefer a generic auto setting in the distributions…

@mficzel
Copy link
Member Author

mficzel commented Aug 16, 2021

In the end it is the neos dev dist that is why i considered it fair to set the config for neos/*.
Adding "*":"auto" in the base dists and "*" : "source" for dev-dists would be fine for me aswell.

@kdambekalns
Copy link
Member

"*" : "source" for dev-dists would be fine for me aswell.

Oh no! Having Symfony, Doctrine, … as source would not be what I want!

@mficzel
Copy link
Member Author

mficzel commented Aug 17, 2021

Thinking about it tend to not like the idea to force composer into a legacy mode with *:auto. often it is best to configure which is important (version control in a dev dist) and leave the rest to the infrastructure.

@kdambekalns
Copy link
Member

into a legacy mode

I am rather unhappy with their choice of wording, TBH. If this was really legacy, they could have named the mode legacy. For me, it does a very logical thing. But that's another story. 🙃

@mficzel
Copy link
Member Author

mficzel commented Aug 17, 2021

We can add *:auto to dev-dists as those can always be changed. I just would not like it on the base-dists. However neos/*:source imho still makes sense for dev-dists anyways.

Copy link
Member

@daniellienert daniellienert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Maybe "flowpack/*": "source" would also be reasonable

…ce to the development collection

Since quite some packages in the flowpack namespace are maintained by neos team members and some are
even installed in a default neos it makes our life easier to install packages from source in the development distribution aswell.
@mficzel mficzel changed the title TASK: Prefer installing of neos packages from source TASK: Prefer installing of neos and flowpack packages from source Aug 17, 2021
@mficzel
Copy link
Member Author

mficzel commented Aug 17, 2021

@daniellienert added "flowpack/*":"source" as suggested ... makes sense and life easier for ourself.

Copy link
Member

@albe albe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as far as I can tell. I'm not sure about the *:auto part but I see the argument that "legacy" is probably a bad framing. It's a "no thoughts needed" mode? Let's decide on that independent of this, since afais we agree that neos/* and flowpack/* should be "source"

@daniellienert daniellienert merged commit 768b557 into master Aug 18, 2021
@daniellienert daniellienert deleted the mficzel-patch-1 branch August 18, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add preferred-install section to composer.json
4 participants