-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Prefer installing of neos and flowpack packages from source #72
Conversation
Since this is the development collection for neos composer should install all neos packages from source. See https://getcomposer.org/doc/06-config.md#preferred-install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is pretty specific, I usually want dev versions of Flowpack or other packages downloaded as source, too. I'd personally prefer a generic auto
setting in the distributions…
In the end it is the neos dev dist that is why i considered it fair to set the config for neos/*. |
Oh no! Having Symfony, Doctrine, … as source would not be what I want! |
Thinking about it tend to not like the idea to force composer into a legacy mode with *:auto. often it is best to configure which is important (version control in a dev dist) and leave the rest to the infrastructure. |
I am rather unhappy with their choice of wording, TBH. If this was really legacy, they could have named the mode |
We can add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
Maybe "flowpack/*": "source"
would also be reasonable
…ce to the development collection Since quite some packages in the flowpack namespace are maintained by neos team members and some are even installed in a default neos it makes our life easier to install packages from source in the development distribution aswell.
@daniellienert added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense as far as I can tell. I'm not sure about the *:auto
part but I see the argument that "legacy" is probably a bad framing. It's a "no thoughts needed" mode? Let's decide on that independent of this, since afais we agree that neos/* and flowpack/* should be "source"
Since this is the development distribution for neos composer should install all neos packages from source.
Since quite some packages in the flowpack namespace are maintained by neos team members and some are
even installed in a default neos it makes our life easier to install packages from source in the development distribution aswell.
See https://getcomposer.org/doc/06-config.md#preferred-install
Resolves: #70