Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PHP 7.3 support for old migration #70

Merged
merged 1 commit into from May 26, 2020
Merged

add PHP 7.3 support for old migration #70

merged 1 commit into from May 26, 2020

Conversation

breadlesscode
Copy link
Contributor

This migration fails with PHP 7.3. But if you use the correct case for the array key, everything works fine 馃憤

@Sebobo
Copy link
Member

Sebobo commented May 7, 2020

Strange. Do you know why that is?

@Sebobo Sebobo merged commit 8fd974b into neos:master May 26, 2020
@Sebobo Sebobo mentioned this pull request May 26, 2020
Closed
kdambekalns added a commit to kdambekalns/neos-googleanalytics that referenced this pull request Jun 8, 2020
@kdambekalns
BUGFIX: Stable check for used character set in migration
b2ad7a1 
The column name can come out of the query used to determine the
character set as upper or lower case (see neos#70, neos#71 and neos#72.)

This uses "AS charsetname" to have a reliable key in the result.

Fixes neos#72
@kdambekalns kdambekalns mentioned this pull request Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@breadlesscode @Sebobo