OpenGrap image (og:image) fetches wrong preset and isn't resized correctly

[putzwasser]

This is a (multiple allowed):

• bug

• Version: Neos.Seo 3.1.0

What you did

Added an landscape orientated OpenGraph image to a document node.

Expected Behavior

Getting a <meta property="og:image" ...> tag with an image asset that has an aspect ratio of 1.91:1 and a max width of 1.200px and a max height of 627px.

Actual Behavior

The og:image tag gets rendered using always the Neos.Seo:OpenGraph.Square preset. Therefore the output is:

<meta property="og:image" content="mysite.local/_Resources/Persistent/4/4/e/e/44eebb9ba7358769a423325474ac3544999d3901/some-big-picture-4401x2309-1080x567.jpg">
<meta property="og:image:width" content="1080">
<meta property="og:image:height" content="567">

This limits the image width to 1080px. That's because this.image.isOrientationLandscape always returns null/false and therefore the Square preset is getting used.

Hotfix by @Sebobo

https://neos-project.slack.com/archives/C050C8FEK/p1597517105446300?thread_ts=1597495125.435700&cid=C050C8FEK

prototype(Neos.Seo:OpenGraphMetaTags) {
    preset = ${'Neos.Seo:OpenGraph.' + (this.image.orientation == 'landscape' ? 'Landscape' : 'Square')}
}