Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Twitter integration #176

Closed
Sebobo opened this issue Aug 11, 2023 · 7 comments
Closed

Remove Twitter integration #176

Sebobo opened this issue Aug 11, 2023 · 7 comments
Assignees
Labels

Comments

@Sebobo
Copy link
Member

Sebobo commented Aug 11, 2023

Twitter does not exist anymore and Mastodon and probably other (newer) networks uses OpenGraph.

@Sebobo Sebobo added the Bug label Aug 11, 2023
@Sebobo
Copy link
Member Author

Sebobo commented Aug 11, 2023

Feedback and opinions are welcome how we should proceed here.
Other CMS are already removing their integrations afaik.

@jonnitto
Copy link
Member

We could also just remove the mixins from Neos.Neos:Page. That way, it would be easy to activate it if someone want's to use it.

@paavo
Copy link
Contributor

paavo commented Aug 11, 2023

We always disabled the "Twitter-Integration" and sticked to OpenGraph only.
I would vote for removing for a cleaner code base.

@kdambekalns
Copy link
Member

Does "X" read OpenGraph? If so, by all means, get rid of it. It not, we might want to leave it in but disable it by default, as @jonnitto suggested.

Possibly tweak the labels to read "X (formerly known as Twitter)". 🤣

@Sebobo
Copy link
Member Author

Sebobo commented Aug 11, 2023

According to their docs they use OpenGraph if available https://developer.twitter.com/en/docs/twitter-for-websites/cards/guides/getting-started#opengraph except for twitter:site twitter:card and twitter:creator, which are "X"-exclusive.
So at least we could remove some of the other attributes in any case.

Another option would be to create a separate package that implements "X" and extends Neos.Seo.

But right now I wouldn't even know what to call things, as the naming could be different next week already again 🤪

@kdambekalns
Copy link
Member

But right now I wouldn't even know what to call things, as the naming could be different next week already again

Well, "X" can stay, it looks like a placeholder anyway. 🤷

Sebobo added a commit that referenced this issue Aug 14, 2023
@Sebobo Sebobo self-assigned this Aug 14, 2023
@Sebobo
Copy link
Member Author

Sebobo commented Aug 14, 2023

So I created a PR to remove everything for Neos 9.

I would leave the rest to the community and for now don't change much for the 3.x branch as long as nothing breaks from their side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants