Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Apply changes" dialog should respect inspector validation #2348

Closed
maya-shines opened this issue Feb 13, 2019 · 3 comments · Fixed by #2352
Closed

"Apply changes" dialog should respect inspector validation #2348

maya-shines opened this issue Feb 13, 2019 · 3 comments · Fixed by #2352
Labels
Bug Label to mark the change as bugfix

Comments

@maya-shines
Copy link
Contributor

If you leave the URL path segment of a page empty, a validator will pop up, informing you that "this property is required". If you're stubborn enough and click "Apply" anyways, the url path segment will be set to an empty string. You are then immediately redirected to the parent page and can't change it anymore in the backend.

@danielkestler
Copy link
Contributor

Similar issue occurs if you manually change the slug to be identical to a sibling page. Then you can forever only load one of the two pages. But this may be a Neos core issue.

@danielkestler danielkestler added Bug Label to mark the change as bugfix Good first issue labels Feb 13, 2019
@dimaip
Copy link
Contributor

dimaip commented Feb 14, 2019

Can't verify on latest 2.x (in Chrome).

Ah, but it's possible to apply if you click away and click Apply in the popup dialog.

@dimaip dimaip changed the title "Apply" shouldn't be allowed on empty url path segment "Apply changes" dialog should respect inspector validation Feb 14, 2019
@kdambekalns
Copy link
Member

With UI 1.3.4 and a field that has validation, neither "Apply" in the inspector, nor "Apply Changes" in the dialog are enabled. This seems to affect only versions > 1.x…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants