-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CKEditor5 to v37 #2836
Comments
If nobody else wants to take care of this I might be able to work on this in december 🤞 |
@nlx-lars You are welcome to provide a PR ❤️ |
Was just reminded again that we neeeeeed to update ^^ Ckeditor is currently moving to typescript (instead of jsdocs) so we should definitely wait for 37 (maybe some breakiness will occur ^^) i know that v22 is pretty breaky for external plugins as the upcast and downcast callback is slightly changed currently v16 conversion.for( 'downcast' ).elementToElement( {
model: 'placeholder',
view: ( modelItem, viewWriter ) => createPlaceholderView( modelItem, viewWriter );
} ); starting with v22 see https://github.com/ckeditor/ckeditor5/releases/tag/v22.0.0 conversion.for( 'downcast' ).elementToElement( {
model: 'placeholder',
view: ( modelItem, { writer: viewWriter } ) => createPlaceholderView( modelItem, viewWriter );
} ); @Reinmar wrote in slack
I think our biggest problem will be plugins (as how can we support two apis at the same time? Wed need to expose the currently used ckeditor version so people can based on their enviroment call the correct api. This is a bit cumbersome for plugin authors but the only way i see. It sure will be a breaking change so 9.0 it is. Another funny thing to see will be wether our manual extracted css will hold up, or if we need the correct build setup: |
also we can get rid of:
and we should also try to fix: #3223 |
Description
Currently v16 is in use. As of creating this issue, https://github.com/ckeditor/ckeditor5/releases/tag/v23.1.0 is the latest release.
The text was updated successfully, but these errors were encountered: